linux-kernel - Re: [RFT PATCH 14/15] drm/radeon: Call drm_helper_force_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a1537b6dc242347783dbe17b055a887.mripard@kernel.org>
Date:   Mon, 04 Sep 2023 07:30:11 +0000
From:   "Maxime Ripard" <mripard@...nel.org>
To:     "Douglas Anderson" <dianders@...omium.org>
Cc:     Xinhui.Pan@....com, airlied@...il.com, alexander.deucher@....com,
        amd-gfx@...ts.freedesktop.org, christian.koenig@....com,
        daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, "Maxime Ripard" <mripard@...nel.org>
Subject: Re: [RFT PATCH 14/15] drm/radeon: Call
 drm_helper_force_disable_all() at shutdown/remove time

On Fri, 1 Sep 2023 16:41:25 -0700, Douglas Anderson wrote:
> Based on grepping through the source code, this driver appears to be
> missing a call to drm_atomic_helper_shutdown(), or in this case the
> non-atomic equivalent drm_helper_force_disable_all(), at system
> shutdown time and at driver remove time. This is important because
> drm_helper_force_disable_all() will cause panels to get disabled
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@...nel.org>

Thanks!
Maxime