linux-kernel - Re: [PATCH] net/mlx5e: Add missing check for xa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv3gD3ePBRYbnd-sJwGA1zuo1VpYoy75ZOFTbShH1GJoqw@mail.gmail.com>
Date:   Mon, 4 Sep 2023 14:27:51 +0530
From:   Pavan Chebbi <pavan.chebbi@...adcom.com>
To:     Chen Ni <nichen@...as.ac.cn>
Cc:     borisp@...dia.com, saeedm@...dia.com, leon@...nel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, sd@...asysnail.net, raeds@...dia.com,
        ehakim@...dia.com, liorna@...dia.com, phaddad@...dia.com,
        atenart@...nel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5e: Add missing check for xa_load

On Mon, Sep 4, 2023 at 1:43 PM Chen Ni <nichen@...as.ac.cn> wrote:
>
> Add check for xa_load() in order to avoid NULL pointer
> dereference.
>
> Fixes: b7c9400cbc48 ("net/mlx5e: Implement MACsec Rx data path using MACsec skb_metadata_dst")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  .../net/ethernet/mellanox/mlx5/core/en_accel/macsec.c  | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
> index c9c1db971652..d2467c0bc3c8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
> @@ -1673,10 +1673,12 @@ void mlx5e_macsec_offload_handle_rx_skb(struct net_device *netdev,
>
>         rcu_read_lock();
>         sc_xarray_element = xa_load(&macsec->sc_xarray, fs_id);
> -       rx_sc = sc_xarray_element->rx_sc;
> -       if (rx_sc) {
> -               dst_hold(&rx_sc->md_dst->dst);
> -               skb_dst_set(skb, &rx_sc->md_dst->dst);
> +       if (sc_xarray_element) {

While the check is good, IMO it is worthwhile to debug why the element
could be NULL. Is the issue xarray or the fs_id?
If you know already, then good idea to update the commit log.

> +               rx_sc = sc_xarray_element->rx_sc;
> +               if (rx_sc) {
> +                       dst_hold(&rx_sc->md_dst->dst);
> +                       skb_dst_set(skb, &rx_sc->md_dst->dst);
> +               }
>         }
>
>         rcu_read_unlock();
> --
> 2.25.1
>
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)