linux-kernel - Re: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPWfZxDuKto6eopt@smile.fi.intel.com>
Date:   Mon, 4 Sep 2023 12:12:07 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Biju Das <biju.das.au@...il.com>
Subject: Re: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()

On Sat, Sep 02, 2023 at 10:09:37AM +0100, Biju Das wrote:
> Add struct mcp23s08_i2c_info and simplify probe() by replacing
> match data 'type' with 'struct mcp23s08_i2c_info'.
> 
> While at it, replace dev_err()->dev_err_probe().

'->' --> ' --> '

...

> +	info = i2c_get_match_data(client);
> +	if (!info)
> +		return dev_err_probe(dev, -EINVAL, "invalid device type (%d)\n",

> +				     info->type);

Huh?! Please, think about it...

-- 
With Best Regards,
Andy Shevchenko