linux-kernel - Re: [PATCH] HID: sony: Fix a potential memory leak in sony

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2309041114500.14207@cbobk.fhfr.pm>
Date:   Mon, 4 Sep 2023 11:14:57 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Pascal Giard <pascal.giard@...mtl.ca>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: sony: Fix a potential memory leak in sony_probe()

On Sun, 3 Sep 2023, Christophe JAILLET wrote:

> If an error occurs after a successful usb_alloc_urb() call, usb_free_urb()
> should be called.
> 
> Fixes: fb1a79a6b6e1 ("HID: sony: fix freeze when inserting ghlive ps3/wii dongles")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> The NULL check is not needed, but I think that it is more informative
> written this way.
> ---
>  drivers/hid/hid-sony.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index dd942061fd77..a02046a78b2d 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -2155,6 +2155,9 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id)
>  	return ret;
>  
>  err:
> +	if (sc->ghl_urb)
> +		usb_free_urb(sc->ghl_urb);
> +

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs