linux-kernel - Re: [PATCH v1 1/2] ALSA: hda/tas2781: Update tas2781 HDA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZPWus9/OCJ/DJHQq@smile.fi.intel.com>
Date:   Mon, 4 Sep 2023 13:17:23 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Shenghao Ding <shenghao-ding@...com>
Cc:     tiwai@...e.de, robh+dt@...nel.org, lgirdwood@...il.com,
        perex@...ex.cz, pierre-louis.bossart@...ux.intel.com,
        kevin-lu@...com, 13916275206@....com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, liam.r.girdwood@...el.com,
        mengdong.lin@...el.com, baojun.xu@...com,
        thomas.gfeller@...rop.com, peeyush@...com, navada@...com,
        broonie@...nel.org, gentuser@...il.com
Subject: Re: [PATCH v1 1/2] ALSA: hda/tas2781: Update tas2781 HDA driver

On Sun, Sep 03, 2023 at 10:37:57PM +0800, Shenghao Ding wrote:
> Support ACPI_ID both TXNW2781 and TIAS2781, and revert structure
> cs35l41_dev_name.

...

> +	/* exactly match either TXNW2781 or TIAS2781 */
> +	/* the rest must be exact matching */
> +	snprintf(tmp, sizeof(tmp), "-%s:00", "TXNW2781");
> +
> +	if (!strcmp(d + n, tmp))
> +		return 1;
> +
>  	/* the rest must be exact matching */
> -	snprintf(tmp, sizeof(tmp), "-%s:00", p->hid);
> +	snprintf(tmp, sizeof(tmp), "-%s:00", "TIAS2781");

Basically this should use acpi_dev_match infra like Intel drivers do.
But I haven't read code deeply to understand if it's the case here or
not.

-- 
With Best Regards,
Andy Shevchenko