linux-kernel - Re: [PATCH v5 1/3] seq_file: Add helper macro to define attribute for rw file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPW3NFT9av+AYwnL@smile.fi.intel.com>
Date:   Mon, 4 Sep 2023 13:53:40 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Xingui Yang <yangxingui@...wei.com>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        john.g.garry@...cle.com, damien.lemoal@...nsource.wdc.com,
        akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
        himanshu.madhani@...ium.com, felipe.balbi@...ux.intel.com,
        gregkh@...uxfoundation.org, uma.shankar@...el.com,
        anshuman.gupta@...el.com, animesh.manna@...el.com,
        linux-usb@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        prime.zeng@...ilicon.com, kangfenglong@...wei.com,
        chenxiang66@...ilicon.com
Subject: Re: [PATCH v5 1/3] seq_file: Add helper macro to define attribute
 for rw file

On Mon, Sep 04, 2023 at 08:48:02AM +0000, Xingui Yang wrote:
> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> for read-only file, but many of drivers want a helper macro for read-write
> file too.
> 
> So we add DEFINE_SHOW_STORE_ATTRIBUTE helper to reduce duplicated code.
> 
> Signed-off-by: Luo Jiaxing <luojiaxing@...wei.com>

I believe you need to preserve Luo's authorship.

Perhaps,
Co-developed-by: Xingui ...
(depending if you really do some job in the certain patch(es) or not).

> Signed-off-by: Xingui Yang <yangxingui@...wei.com>

Code wise LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko