linux-kernel - Re: [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw87390"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3ada071-4c8e-f65d-ad75-655370ba2c55@linaro.org>
Date:   Mon, 4 Sep 2023 14:14:31 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     wangweidong.a@...nic.com, lgirdwood@...il.com, broonie@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, perex@...ex.cz, tiwai@...e.com,
        rf@...nsource.cirrus.com, herve.codina@...tlin.com,
        shumingf@...ltek.com, rdunlap@...radead.org, 13916275206@....com,
        ryans.lee@...log.com, linus.walleij@...aro.org,
        ckeepax@...nsource.cirrus.com, yijiangtao@...nic.com,
        liweilei@...nic.com, colin.i.king@...il.com, trix@...hat.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     zhangjianming@...nic.com
Subject: Re: [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw87390"

On 04/09/2023 13:46, wangweidong.a@...nic.com wrote:
> From: Weidong Wang <wangweidong.a@...nic.com>
> 
> Add a DT schema for describing awinic aw87390 audio amplifiers.
> They are controlled using I2C.

Thank you for your patch. There is something to discuss/improve.


> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: awinic,aw87390
> +
> +  reg:
> +    maxItems: 1

No reset-gpios? Shouldn't this be just merged with awinic,aw88395 bindings?

Missing sound-dai-cells (const: 0 or 1)

> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        audio-codec@58 {
> +            compatible = "awinic,aw87390";
> +            reg = <0x58>;

Please add sound-dai-cells for the example to be complete.

Best regards,
Krzysztof