linux-kernel - Re: [PATCH] comedi: Fix driver module dependencies since HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8728313c-997a-46c1-8225-d57369e9292c@app.fastmail.com>
Date:   Mon, 04 Sep 2023 09:34:01 -0400
From:   "Arnd Bergmann" <arnd@...nel.org>
To:     "Ian Abbott" <abbotti@....co.uk>,
        "Niklas Schnelle" <schnelle@...ux.ibm.com>,
        linux-kernel@...r.kernel.org
Cc:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Hartley Sweeten" <hsweeten@...ionengravers.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH] comedi: Fix driver module dependencies since HAS_IOPORT changes

On Mon, Sep 4, 2023, at 08:01, Ian Abbott wrote:
> On 04/09/2023 12:23, Niklas Schnelle wrote:
>> On Mon, 2023-09-04 at 11:10 +0100, Ian Abbott wrote:
>
> Thanks for the confirmation.  Will it be safe to assume that anything 
> that selects ISA will also select HAS_IOPORT?  That is trivially the 
> case for arch/{alpha,arm,x86}; arch/mips explicitly selects HAS_IOPORT 
> if ISA is selected; arch/powerpc explicitly selects HAS_IOPORT if PCI is 
> selected and it is only possible to configure ISA if PPC_CHRP is 
> configured which selects FORCE_PCI and therefore selects PCI and 
> therefore selects HAS_IOPORT; arch/um does not select HAS_IOPORT and 
> although it has a 'config ISA', nothing appears to select it.  None of 
> the remaining arch/* have 'select ISA'.

Yes, I think that will always be a safe assumption, ISA without port I/O
is just not a sensible configuration. A few of the later ISA devices use
PCI style memory mapped I/O, but I can't think of any driver that doesn't
also require port I/O, and you wouldn't find ISA slots in a system that
lacks support for port I/O.

      Arnd