linux-kernel - Re: [RFC PATCH 2/3] reset: Add th1520 reset driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a19f9b10-f65f-6719-635f-06bc10b79c61@linaro.org>
Date:   Mon, 4 Sep 2023 16:19:23 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Kwanghoon Son <k.son@...sung.com>, p.zabel@...gutronix.de,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, jszhang@...nel.org, guoren@...nel.org,
        wefu@...hat.com, paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, inki.dae@...sung.com
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org
Subject: Re: [RFC PATCH 2/3] reset: Add th1520 reset driver support

On 04/09/2023 06:25, Kwanghoon Son wrote:
> This driver supports th1520 T-HEAD SoC reset platform device.
> 
> Signed-off-by: Kwanghoon Son <k.son@...sung.com>
> ---
>  drivers/reset/Kconfig                    |  10 +++
>  drivers/reset/Makefile                   |   1 +
>  drivers/reset/reset-th1520.c             | 109 +++++++++++++++++++++++
>  include/dt-bindings/reset/th1520-reset.h |   9 ++

Bindings are always separate patches. In this case, all bindings should
be together. Also you clearly forgot one step:

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof