linux-kernel - Re: [PATCH] cxl/mbox: Fix CEL logic for poison and security commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <v4gxbhybb2zhxowdyn6ri6tham22aemfvqc4xu7r65x6uhp6zi@2fiholdfp6sb>
Date:   Mon, 4 Sep 2023 10:24:34 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Ira Weiny <ira.weiny@...el.com>
Cc:     Jonathan Cameron <jonathan.cameron@...wei.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cxl/mbox: Fix CEL logic for poison and security commands

On Sun, 03 Sep 2023, Ira Weiny wrote:

>The following debug output was observed while testing CXL
>
>cxl_core:cxl_walk_cel:721: cxl_mock_mem cxl_mem.0: Opcode 0x4300 unsupported by driver
>
>opcode 0x4300 (Get Poison) is supported by the driver and the mock
>device supports it.  The logic should be checking that the opcode is
>both not poison and not security.
>
>Fix the logic to allow poison and security commands.

Hmm yeah sorry about that.

Reviewed-by: Davidlohr Bueso <dave@...olabs.net>

>
>Fixes: ad64f5952ce3 ("cxl/memdev: Only show sanitize sysfs files when supported")
>Cc: Davidlohr Bueso <dave@...olabs.net>
>Signed-off-by: Ira Weiny <ira.weiny@...el.com>
>---
> drivers/cxl/core/mbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
>index ca60bb8114f2..b315bdab9197 100644
>--- a/drivers/cxl/core/mbox.c
>+++ b/drivers/cxl/core/mbox.c
>@@ -716,8 +716,8 @@ static void cxl_walk_cel(struct cxl_memdev_state *mds, size_t size, u8 *cel)
>		u16 opcode = le16_to_cpu(cel_entry[i].opcode);
>		struct cxl_mem_command *cmd = cxl_mem_find_command(opcode);
>
>-		if (!cmd && (!cxl_is_poison_command(opcode) ||
>-			     !cxl_is_security_command(opcode))) {
>+		if (!cmd && !cxl_is_poison_command(opcode) &&
>+		    !cxl_is_security_command(opcode)) {
>			dev_dbg(dev,
>				"Opcode 0x%04x unsupported by driver\n", opcode);
>			continue;
>
>---
>base-commit: 1c59d383390f970b891b503b7f79b63a02db2ec5
>change-id: 20230903-cxl-cel-fix-9da269bf0f21
>
>Best regards,
>--
>Ira Weiny <ira.weiny@...el.com>
>