linux-kernel - Re: [PATCH 0/3] Fix tcsr_mutex register for IPQ6018

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ba49071-c97a-4657-af67-0abf93cfa0d7@quicinc.com>
Date:   Mon, 4 Sep 2023 22:57:31 +0530
From:   Vignesh Viswanathan <quic_viswanat@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <ohad@...ery.com>,
        <baolin.wang@...ux.alibaba.com>, <linux-remoteproc@...r.kernel.org>
CC:     <quic_kathirav@...cinc.com>, <quic_anusha@...cinc.com>,
        <quic_sjaganat@...cinc.com>, <quic_srichara@...cinc.com>,
        <quic_varada@...cinc.com>
Subject: Re: [PATCH 0/3] Fix tcsr_mutex register for IPQ6018



On 9/4/2023 9:28 PM, Konrad Dybcio wrote:
> On 4.09.2023 07:50, Vignesh Viswanathan wrote:
>> IPQ6018 has 32 tcsr_mutext hwlock registers of 0x1000 size each.
>> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
>> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
>> and doesn't match the HW present in IPQ6018.
>>
>> This series fixes the following:
>> 1. Fix the tcsr_mutex hwlock register size to 0x20000 in ipq6018.dtsi.
>> 2. Remove qcom,ipq6018-tcsr-mutex compatible string for tcsr_mutex in
>> ipq6018.dtsi.
>> 3. Drop unused qcom,ipq6018-tcsr-mutex compatible string from
>> qcom_hwspinlock driver and dt-bindings.
>>
> Sounds like 20230904063344.4144086-1-quic_viswanat@...cinc.com can't
> go in without this then?
> 

They can independently go in as the current max size and stride set for
IPQ6018 still has 32 locks and moving the index 3 shouldn't cause any 
issues.

However, functionally IPQ6018's HW lock is broken and will be fixed once 
this series goes in.

Thanks,
Vignesh
> Konrad