linux-kernel - Re: [PATCH] tpm: Don't make vendor check required for probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CVAC6ASBH8W5.B7SB98LQT87B@suppilovahvero>
Date:   Mon, 04 Sep 2023 21:15:04 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Dusty Mabe" <dusty@...tymabe.com>,
        "Mario Limonciello" <mario.limonciello@....com>
Cc:     <linux-integrity@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Thorsten Leemhuis" <regressions@...mhuis.info>,
        <charles.d.prestopine@...el.com>, <rafael.j.wysocki@...el.com>,
        <len.brown@...el.com>, <stable@...r.kernel.org>,
        "Todd Brandt" <todd.e.brandt@...el.com>
Subject: Re: [PATCH] tpm: Don't make vendor check required for probe

On Mon Aug 28, 2023 at 6:47 PM EEST, Dusty Mabe wrote:
>
>
> On 8/18/23 14:15, Mario Limonciello wrote:
> > The vendor check introduced by commit 554b841d4703 ("tpm: Disable RNG for
> > all AMD fTPMs") doesn't work properly on Intel fTPM.  The TPM doesn't reply
> > at bootup and returns back the command code.
> > 
> > As this isn't crucial for anything but AMD fTPM and AMD fTPM works, throw
> > away the error code to let Intel fTPM continue to work.
> > 
>
> FWIW there is a Fedora bug where several people are reporting similar issues:
> https://bugzilla.redhat.com/show_bug.cgi?id=2232888
>
> Dusty

I just sent v4 with reported-by's added despite:

1. checkpatch.pl complaining about them
2. no mention of the bugzilla in the kernel documentation at least not
   in the sections describing the process handling the patches

BR, Jarkko