[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <2C8H0S.90380B1U7TPP3@somainline.org>
Date: Mon, 04 Sep 2023 21:48:02 +0200
From: Martin Botka <martin.botka@...ainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Mark Rutland <mark.rutland@....com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Sudeep Holla <sudeep.holla@....com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Viresh Kumar <viresh.kumar@...aro.org>,
Yangtao Li <tiny.windzz@...il.com>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org, linux-sunxi@...ts.linux.dev,
devicetree@...r.kernel.org,
Andre Przywara <andre.przywara@....com>,
Alan Ma <tech@...u3d.com>,
Luke Harrison <bttuniversity@...u3d.com>,
Marijn Suijten <marijn.suijten@...ainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...ainline.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Rogerio Goncalves <rogerlz@...il.com>,
Martin Botka <martin@...u3d.com>
Subject: Re: [PATCH 3/6] dt-bindings: opp: Add compatible for H616
On Mon, Sep 4 2023 at 09:32:44 PM +02:00:00, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> On 04/09/2023 21:31, Krzysztof Kozlowski wrote:
>> On 04/09/2023 17:57, Martin Botka wrote:
>>> We need to add compatible for H616 to H6 cpufreq driver bindings.
>>
>> Please describe the hardware, not what is needed for drivers.
>>
>>>
>>> Also enable opp_supported_hw property that will be needed for H616.
>>>
>>> Signed-off-by: Martin Botka <martin.botka@...ainline.org>
>>> ---
>>> .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>>> | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>>> index 51f62c3ae194..2fa1199f2d23 100644
>>> ---
>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>>> +++
>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>>> @@ -23,7 +23,10 @@ allOf:
>>>
>>> properties:
>>> compatible:
>>> - const: allwinner,sun50i-h6-operating-points
>>> + contains:
>>
>> This does not look like part of allOf, so contains is no correct
>> here.
>> This must be specific, so drop contains.
>
> BTW, I also do no see it used by the driver at all.
Function sun50i_cpufreq_get_efuse uses it. It checks for H6 compatible
and if that fails we check for H616 compatible.
Also im double checking for H6. Nice screwup on my side :)
Cheers,
Martin
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists