linux-kernel - Re: [PATCH V1 3/3] ASoC: codecs: Add aw87390 amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Sep 2023 22:21:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     wangweidong.a@...nic.com
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        perex@...ex.cz, tiwai@...e.com, rf@...nsource.cirrus.com,
        herve.codina@...tlin.com, shumingf@...ltek.com,
        rdunlap@...radead.org, 13916275206@....com, ryans.lee@...log.com,
        ckeepax@...nsource.cirrus.com, yijiangtao@...nic.com,
        liweilei@...nic.com, colin.i.king@...il.com, trix@...hat.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhangjianming@...nic.com
Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw87390 amplifier driver

Hi Weidong,

thanks for your patch!

On Mon, Sep 4, 2023 at 1:47 PM <wangweidong.a@...nic.com> wrote:

> From: Weidong Wang <wangweidong.a@...nic.com>
>
> Add i2c and amplifier registration for aw87390 and
> their associated operation functions.
>
> Signed-off-by: Weidong Wang <wangweidong.a@...nic.com>
(...)
> +#include <linux/of_gpio.h>

Please do not include this deprecated header.

Also: it seems you do not even use it so it's unnecessary.

Yours,
Linus Walleij