lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <ZPUrXvIVwtVmPvzI@rli9-mobl>
Date:   Mon, 4 Sep 2023 08:57:02 +0800
From:   kernel test robot <philip.li@...el.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@...il.com>
CC:     <llvm@...ts.linux.dev>, <oe-kbuild-all@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>, Mark Brown <broonie@...nel.org>
Subject: kernel/reboot.c:559: warning: Function parameter or member
 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   92901222f83d988617aee37680cb29e1a743b5e4
commit: dfa19b11385d4cf8f0242fd93e2073e25183c331 reboot: Add hardware protection power-off
date:   2 years, 2 months ago
:::::: branch date: 21 hours ago
:::::: commit date: 2 years, 2 months ago
config: i386-allnoconfig (attached as .config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (attached as reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309040349.HLOK1O5I-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/reboot.c:215: warning: Function parameter or member 'cmd' not described in 'do_kernel_restart'
>> kernel/reboot.c:559: warning: Function parameter or member 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'


vim +559 kernel/reboot.c

dfa19b11385d4cf Matti Vaittinen 2021-06-03  548  
dfa19b11385d4cf Matti Vaittinen 2021-06-03  549  static DECLARE_DELAYED_WORK(hw_failure_emergency_poweroff_work,
dfa19b11385d4cf Matti Vaittinen 2021-06-03  550  			    hw_failure_emergency_poweroff_func);
dfa19b11385d4cf Matti Vaittinen 2021-06-03  551  
dfa19b11385d4cf Matti Vaittinen 2021-06-03  552  /**
dfa19b11385d4cf Matti Vaittinen 2021-06-03  553   * hw_failure_emergency_poweroff - Trigger an emergency system poweroff
dfa19b11385d4cf Matti Vaittinen 2021-06-03  554   *
dfa19b11385d4cf Matti Vaittinen 2021-06-03  555   * This may be called from any critical situation to trigger a system shutdown
dfa19b11385d4cf Matti Vaittinen 2021-06-03  556   * after a given period of time. If time is negative this is not scheduled.
dfa19b11385d4cf Matti Vaittinen 2021-06-03  557   */
dfa19b11385d4cf Matti Vaittinen 2021-06-03  558  static void hw_failure_emergency_poweroff(int poweroff_delay_ms)
dfa19b11385d4cf Matti Vaittinen 2021-06-03 @559  {
dfa19b11385d4cf Matti Vaittinen 2021-06-03  560  	if (poweroff_delay_ms <= 0)
dfa19b11385d4cf Matti Vaittinen 2021-06-03  561  		return;
dfa19b11385d4cf Matti Vaittinen 2021-06-03  562  	schedule_delayed_work(&hw_failure_emergency_poweroff_work,
dfa19b11385d4cf Matti Vaittinen 2021-06-03  563  			      msecs_to_jiffies(poweroff_delay_ms));
dfa19b11385d4cf Matti Vaittinen 2021-06-03  564  }
dfa19b11385d4cf Matti Vaittinen 2021-06-03  565  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Download attachment ".config.gz" of type "application/gzip" (8755 bytes)

View attachment "reproduce" of type "text/plain" (838 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ