linux-kernel - Re: [PATCH v2] media: dt-bindings: Merge OV5695 into OV5693 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169394725610.3997729.730832978386837870.robh@kernel.org>
Date:   Tue, 5 Sep 2023 15:54:17 -0500
From:   Rob Herring <robh@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Heiko Stuebner <heiko@...ech.de>,
        linux-rockchip@...ts.infradead.org,
        Conor Dooley <conor+dt@...nel.org>,
        Tommaso Merciai <tommaso.merciai@...rulasolutions.com>,
        Daniel Scally <djrscally@...il.com>,
        Helen Koike <helen.koike@...labora.com>,
        linux-kernel@...r.kernel.org,
        Conor Dooley <conor.dooley@...rochip.com>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Dafna Hirschfeld <dafna@...tmail.com>,
        devicetree@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v2] media: dt-bindings: Merge OV5695 into OV5693 binding


On Thu, 17 Aug 2023 15:26:46 -0500, Rob Herring wrote:
> The OV5695 binding is almost the same as the OV5693 binding. The only
> difference is 'clock-names' is defined for OV5695. However, the lack of
> clock-names is an omission as the Linux OV5693 driver expects the same
> 'xvclk' clock name.
> 
> 'link-frequencies' is required by OV5693, but not OV5695, so make that
> conditional. Really, this shouldn't vary by device, but we're stuck with
> the existing binding use.
> 
> The rockchip-isp1 binding example is missing required properties, so it
> has to be updated as well.
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> v2:
>  - Make link-frequencies conditionally required
> ---
>  .../devicetree/bindings/media/i2c/ov5695.txt  | 41 -------------------
>  .../bindings/media/i2c/ovti,ov5693.yaml       | 31 ++++++++++----
>  .../bindings/media/rockchip-isp1.yaml         |  1 +
>  3 files changed, 25 insertions(+), 48 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5695.txt
> 

Applied, thanks!