linux-kernel - RE: [PATCH v2 3/5] usb: pd: Add helper macro to get Type C cable speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR11MB0048D7DE0329B6EDD2222E80A9E8A@MWHPR11MB0048.namprd11.prod.outlook.com>
Date:   Tue, 5 Sep 2023 23:47:24 +0000
From:   "Patel, Utkarsh H" <utkarsh.h.patel@...el.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "pmalani@...omium.org" <pmalani@...omium.org>,
        "chrome-platform@...ts.linux.dev" <chrome-platform@...ts.linux.dev>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "bleung@...omium.org" <bleung@...omium.org>
Subject: RE: [PATCH v2 3/5] usb: pd: Add helper macro to get Type C cable
 speed

Hi Heikki,

Thank you for the review.

> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Sent: Monday, September 4, 2023 12:12 AM
> To: Patel, Utkarsh H <utkarsh.h.patel@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org;
> pmalani@...omium.org; chrome-platform@...ts.linux.dev;
> andriy.shevchenko@...ux.intel.com; bleung@...omium.org
> Subject: Re: [PATCH v2 3/5] usb: pd: Add helper macro to get Type C cable
> speed
> 
> On Mon, Sep 04, 2023 at 10:08:42AM +0300, Heikki Krogerus wrote:
> > On Wed, Aug 30, 2023 at 03:39:48PM -0700, Utkarsh Patel wrote:
> > > Added a helper macro to get the Type C cable speed when provided the
> > > cable VDO.
> > >
> > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@...el.com>
> >
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> >
> > > ---
> > > Changes in v2:
> > > - This change is being added as new patch in this series.
> > >
> > >  include/linux/usb/pd_vdo.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/include/linux/usb/pd_vdo.h b/include/linux/usb/pd_vdo.h
> > > index b057250704e8..3a747938cdab 100644
> > > --- a/include/linux/usb/pd_vdo.h
> > > +++ b/include/linux/usb/pd_vdo.h
> > > @@ -376,6 +376,7 @@
> > >  	 | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) & 0x3) << 5
> 	\
> > >  	 | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7))
> > >
> > > +#define VDO_TYPEC_CABLE_SPEED(vdo)	((vdo) & 0x7)
> > >  #define VDO_TYPEC_CABLE_TYPE(vdo)	(((vdo) >> 18) & 0x3)
> 
> Hold on! You are not using this anywhere in the patch set?
> 
> Since this is just a helper, I think it would be appropriate to introduce it
> together with a user for it.
> 

Ack. 

Sincerely,
Utkarsh Patel.