[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230905090258.GC31594@pendragon.ideasonboard.com>
Date: Tue, 5 Sep 2023 12:02:58 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Alain Volmat <alain.volmat@...s.st.com>
Cc: Hugues Fruchet <hugues.fruchet@...s.st.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Russell King <linux@...linux.org.uk>,
Philipp Zabel <p.zabel@...gutronix.de>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Dan Scally <dan.scally@...asonboard.com>,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/5] ARM: dts: stm32: add dcmipp support to stm32mp135
Hi Alain,
Thank you for the patch.
On Fri, Sep 01, 2023 at 05:57:23PM +0200, Alain Volmat wrote:
> From: Hugues Fruchet <hugues.fruchet@...s.st.com>
>
> Add dcmipp support to STM32MP135.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@...s.st.com>
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>
> ---
> arch/arm/boot/dts/st/stm32mp135.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/st/stm32mp135.dtsi b/arch/arm/boot/dts/st/stm32mp135.dtsi
> index abf2acd37b4e..beee9ec7ed0d 100644
> --- a/arch/arm/boot/dts/st/stm32mp135.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp135.dtsi
> @@ -8,5 +8,13 @@
>
> / {
> soc {
> + dcmipp: dcmipp@...00000 {
> + compatible = "st,stm32mp13-dcmipp";
> + reg = <0x5a000000 0x400>;
> + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&rcc DCMIPP_R>;
> + clocks = <&rcc DCMIPP_K>;
> + status = "disabled";
This needs a port, as it's marked as required in the bindings. You can
leave the endpoint out.
With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> + };
> };
> };
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists