linux-kernel - Re: [PATCH] mm: fix unaccount of memory on vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230905131209.4xacdbisz4hvj2cf@revolver>
Date:   Tue, 5 Sep 2023 09:12:09 -0400
From:   "Liam R. Howlett" <Liam.Howlett@...cle.com>
To:     Anthony Yznaga <anthony.yznaga@...cle.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, willy@...radead.org
Subject: Re: [PATCH] mm: fix unaccount of memory on vma_link() failure

* Anthony Yznaga <anthony.yznaga@...cle.com> [230829 20:43]:
> Fix insert_vm_struct() so that only accounted memory is unaccounted
> if vma_link() fails.
> 
> Fixes: d4af56c5c7c6 ("mm: start tracking VMAs with maple tree")
> Signed-off-by: Anthony Yznaga <anthony.yznaga@...cle.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> ---
>  mm/mmap.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 514ced13c65c..f8c084017757 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -3278,7 +3278,8 @@ int insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
>  	}
>  
>  	if (vma_link(mm, vma)) {
> -		vm_unacct_memory(charged);
> +		if (vma->vm_flags & VM_ACCOUNT)
> +			vm_unacct_memory(charged);
>  		return -ENOMEM;
>  	}
>  
> -- 
> 2.39.3
>