linux-kernel - Re: [PATCH v4 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18b78489-6a12-a09f-620d-985be747f9da@gmail.com>
Date:   Tue, 5 Sep 2023 17:55:25 +0800
From:   PeterYin <peteryin.openbmc@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        patrick@...cx.xyz, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        soc@...nel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc:     cosmo.chou@...ntatw.com, potin.lai@...ntatw.com,
        daniel-hsu@...ntatw.com
Subject: Re: [PATCH v4 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva
 (AST2600) BMC


On 8/30/23 17:44, Krzysztof Kozlowski wrote:
> On 30/08/2023 11:02, peteryin wrote:
>> Add linux device tree entry related to
>> Minerva specific devices connected to BMC SoC.
>>
>> Signed-off-by: peteryin <peteryin.openbmc@...il.com>
> To clarify: your full name or known identity is "peteryin"?
>
>> ---
>>   arch/arm/boot/dts/Makefile                    |   1 +
>>   .../boot/dts/aspeed-bmc-facebook-minerva.dts  | 385 ++++++++++++++++++
>>   2 files changed, 386 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 9e1d7bf3cff6..edb0b2105333 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>>   	aspeed-bmc-facebook-wedge400.dtb \
>>   	aspeed-bmc-facebook-yamp.dtb \
>>   	aspeed-bmc-facebook-yosemitev2.dtb \
>> +	aspeed-bmc-facebook-minerva.dtb \
> Nothing improved here.
>
>>   	aspeed-bmc-ibm-bonnell.dtb \
>>   	aspeed-bmc-ibm-everest.dtb \
>>   	aspeed-bmc-ibm-rainier.dtb \
>
>> +	"","","","","","","","",
>> +	/*O0-O3 line 224-231*/
>> +	"","","","","","","","",
>> +	/*O4-O7 line 232-239*/
>> +	"","","","","","","","",
>> +	/*P0-P3 line 240-247*/
>> +	"","","","","","","","",
>> +	/*P4-P7 line 248-255*/
>> +	"","","","","","","","";
>> +};
>> +
> Nor here.
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
Could you please clarify for me?

Are you asking if the last line should not have a blank line, or I can't 
set a comment for the sgpio line like this:

/*P4-P7 line 248-255*/

> Thank you.
>
> Best regards,
> Krzysztof
>