linux-kernel - Re: [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw87390"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b6e5216-4718-7bba-ff0d-3b0e01291cdd@linaro.org>
Date:   Tue, 5 Sep 2023 08:33:30 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     wangweidong.a@...nic.com
Cc:     13916275206@....com, alsa-devel@...a-project.org,
        broonie@...nel.org, ckeepax@...nsource.cirrus.com,
        colin.i.king@...il.com, conor+dt@...nel.org,
        devicetree@...r.kernel.org, herve.codina@...tlin.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        liweilei@...nic.com, perex@...ex.cz, rdunlap@...radead.org,
        rf@...nsource.cirrus.com, robh+dt@...nel.org, ryans.lee@...log.com,
        shumingf@...ltek.com, tiwai@...e.com, trix@...hat.com,
        yijiangtao@...nic.com, zhangjianming@...nic.com
Subject: Re: [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw87390"

On 05/09/2023 05:31, wangweidong.a@...nic.com wrote:
>>> +examples:
>>> +  - |
>>> +    i2c {
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +        audio-codec@58 {
>>> +            compatible = "awinic,aw87390";
>>> +            reg = <0x58>;
> 
>> Please add sound-dai-cells for the example to be complete.
> 
> Thank you very much, I will modify it in patch v2

I expect in example all properties your device can use. Not only some
subset you want to add just to satisfy my comment above.

Best regards,
Krzysztof