linux-kernel - Re: [PATCH] samples/bpf: Add sample usage for BPF_PROG_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <279bb09e.54ab.18a64fd47e8.Coremail.00107082@163.com>
Date:   Tue, 5 Sep 2023 18:57:15 +0800 (CST)
From:   "David Wang" <00107082@....com>
To:     "Donald Hunter" <donald.hunter@...il.com>
Cc:     fw@...len.de, "Alexei Starovoitov" <ast@...nel.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        "Andrii Nakryiko" <andrii@...nel.org>,
        "Martin KaFai Lau" <martin.lau@...ux.dev>,
        "Song Liu" <song@...nel.org>,
        "Yonghong Song" <yonghong.song@...ux.dev>,
        "John Fastabend" <john.fastabend@...il.com>,
        "KP Singh" <kpsingh@...nel.org>,
        "Stanislav Fomichev" <sdf@...gle.com>,
        "Hao Luo" <haoluo@...gle.com>, "Jiri Olsa" <jolsa@...nel.org>,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH] samples/bpf: Add sample usage for
 BPF_PROG_TYPE_NETFILTER


At 2023-09-05 17:05:26, "Donald Hunter" <donald.hunter@...il.com> wrote:
>David Wang <00107082@....com> writes:
>
>> This sample code implements a simple ipv4
>> blacklist via the new bpf type BPF_PROG_TYPE_NETFILTER,
>> which was introduced in 6.4.
>>
>> The bpf program drops package if destination ip address
>> hits a match in the map of type BPF_MAP_TYPE_LPM_TRIE,
>>
>> The userspace code would load the bpf program,
>> attach it to netfilter's FORWARD/OUTPUT hook,
>> and then write ip patterns into the bpf map.
>>
>> Signed-off-by: David Wang <00107082@....com>
>> ---
>>  samples/bpf/Makefile                      |  3 +
>>  samples/bpf/netfilter_ip4_blacklist.bpf.c | 62 +++++++++++++++
>>  samples/bpf/netfilter_ip4_blacklist.c     | 96 +++++++++++++++++++++++
>>  3 files changed, 161 insertions(+)
>>  create mode 100644 samples/bpf/netfilter_ip4_blacklist.bpf.c
>>  create mode 100644 samples/bpf/netfilter_ip4_blacklist.c
>
>According to https://docs.kernel.org/process/coding-style.html#naming
>you should avoid new use of blacklist. You should use somethink like
>denylist or blocklist instead.

Thanks for the information~! 
I will make the changes, and resend a patch if samples/bpf is still a good place to put the code.