linux-kernel - Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fd16cae-483c-4145-ae59-ee1775005fa8@kadam.mountain>
Date:   Tue, 5 Sep 2023 14:19:17 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Dongliang Mu <dzm91@...t.edu.cn>
Cc:     Toke Høiland-Jørgensen <toke@...e.dk>,
        Kalle Valo <kvalo@...nel.org>,
        hust-os-kernel-patches@...glegroups.com,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb_resume

On Tue, Sep 05, 2023 at 09:35:56AM +0800, Dongliang Mu wrote:
> In ath9k_hif_usb_resume, the error handling code calls
> ath9k_hif_usb_dealloc_urbs twice in different paths.
> 
> To unify the error handling code, we move the else branch before
> the if branch and drop one level of indentation of the if branch.
> 
> In addition, move the ret variable at the end of variable declarations
> to be reverse x-mas tree order.
> 
> Note that this patch does not incur any functionability change.
> 
> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
> ---
>  drivers/net/wireless/ath/ath9k/hif_usb.c | 34 ++++++++++++------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> v1->v2: move the else branch on top of if branch;
>         move ret variable at the end of variable declarations;

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter