linux-kernel - RE: [PATCH v4 04/10] net/socket: Break down __sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9d56ef784ad436c8cb60c4c9fd2d786@AcuMS.aculab.com>
Date:   Tue, 5 Sep 2023 09:36:34 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Breno Leitao' <leitao@...ian.org>,
        "sdf@...gle.com" <sdf@...gle.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "asml.silence@...il.com" <asml.silence@...il.com>,
        "willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
        "martin.lau@...ux.dev" <martin.lau@...ux.dev>,
        "krisman@...e.de" <krisman@...e.de>,
        "Alexei Starovoitov" <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "Andrii Nakryiko" <andrii@...nel.org>, Song Liu <song@...nel.org>,
        Yonghong Song <yonghong.song@...ux.dev>,
        John Fastabend <john.fastabend@...il.com>,
        "KP Singh" <kpsingh@...nel.org>, Hao Luo <haoluo@...gle.com>,
        Jiri Olsa <jolsa@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
CC:     "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "io-uring@...r.kernel.org" <io-uring@...r.kernel.org>,
        Kuniyuki Iwashima <kuniyu@...zon.com>,
        "Alexander Mikhalitsyn" <alexander@...alicyn.com>,
        Xin Long <lucien.xin@...il.com>,
        "David Howells" <dhowells@...hat.com>,
        Jason Xing <kernelxing@...cent.com>,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>
Subject: RE: [PATCH v4 04/10] net/socket: Break down __sys_getsockopt

From: Breno Leitao
> Sent: 04 September 2023 17:25
> 
> Split __sys_getsockopt() into two functions by removing the core
> logic into a sub-function (do_sock_getsockopt()). This will avoid
> code duplication when doing the same operation in other callers, for
> instance.

Although a lot more work, I think (others may disagree) that
the internal getsockopt() functions should be changed to take
the length as a parameter and return the positive value
to write back.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)