linux-kernel - Re: [PATCH 3/4] drm/bridge: lt8912b: Manually disable HPD only if it was enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c04a6f0-d7ec-6efd-7b33-774ce4d5548d@ideasonboard.com>
Date:   Tue, 5 Sep 2023 10:28:06 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Marcel Ziswiler <marcel.ziswiler@...adex.com>
Cc:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Laurent.pinchart@...asonboard.com" 
        <Laurent.pinchart@...asonboard.com>,
        "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
        "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
        Stefan Eichenberger <stefan.eichenberger@...adex.com>,
        "adrien.grassein@...il.com" <adrien.grassein@...il.com>,
        "rfoss@...nel.org" <rfoss@...nel.org>,
        "airlied@...il.com" <airlied@...il.com>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        "jonas@...boo.se" <jonas@...boo.se>,
        "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>
Subject: Re: [PATCH 3/4] drm/bridge: lt8912b: Manually disable HPD only if it
 was enabled

On 04/09/2023 21:08, Marcel Ziswiler wrote:
> Hi Tomi
> 
> Looks good. Thanks! Tested both on Verdin AM62 as well as on Verdin iMX8M Mini.
> 
> Just a minor nit-pick in your commit message.
> 
> On Fri, 2023-08-04 at 13:48 +0300, Tomi Valkeinen wrote:
>> lt8912b only calls drm_bridge_hpd_enable() if it creates a connector and
>> the next bridge has DRM_BRIDGE_OP_HPD set. However, when calling
>> drm_bridge_hpd_disable() it misses checking if a connector was created,
>> calling drm_bridge_hpd_disable() even if HPD was nenver enabled. I don't
> 
> was never enabled
> 
>> see any issues causing by this wrong call, though.
> 
> any issues caused by this wrong call
> 
>> Add the check to avoid wrongly calling drm_bridge_hpd_disable().
>>
>> Fixes: 3b0a01a6a522 ("drm/bridge: lt8912b: Add hot plug detection")
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> 
> For the whole series:
> 
> Tested-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>

Thanks! I have fixed the typos in the desc.

  Tomi