linux-kernel - Re: [PATCH 2/4] remoteproc: qcom: pas: Add sc7180 adsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96006deefd7a10a65db5d84ad319524a@trvn.ru>
Date:   Tue, 05 Sep 2023 15:24:59 +0500
From:   Nikita Travkin <nikita@...n.ru>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        cros-qcom-dts-watchers@...omium.org,
        David Wronek <davidwronek@...il.com>,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/4] remoteproc: qcom: pas: Add sc7180 adsp

Konrad Dybcio писал(а) 05.09.2023 13:35:
> On 5.09.2023 07:47, Nikita Travkin wrote:
>> sc7180 has a dedicated ADSP similar to the one found in sm8250.
>> Add it's compatible to the driver reusing the existing config so
>> the devices that use the adsp can probe it.
>>
>> Signed-off-by: Nikita Travkin <nikita@...n.ru>
>> ---
>>  drivers/remoteproc/qcom_q6v5_pas.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
>> index b5447dd2dd35..55fafc68200e 100644
>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>> @@ -1161,6 +1161,7 @@ static const struct of_device_id adsp_of_match[] = {
>>  	{ .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init },
>>  	{ .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init },
>>  	{ .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init },
>> +	{ .compatible = "qcom,sc7180-adsp-pas", .data = &sm8250_adsp_resource},
> Should we use a fallback here, maybe?
> 

Not sure if it makes sense to, given afaiu no other soc defines two
compatibles for the adsp right now...

> Konrad