linux-kernel - Re: [PATCH 2/4] i2c: at91-master: devm_pinctrl_get() cannot return NULL

Open Source and information security mailing list archives

Message-ID: <d7b08ce2-fda4-fd6c-5ef0-14d1a9c25e14@microchip.com>
Date:   Tue, 5 Sep 2023 10:42:14 +0000
From:   <Hari.PrasathGE@...rochip.com>
To:     <yann@...nneau.net>, <andi.shyti@...nel.org>,
        <codrin.ciubotariu@...rochip.com>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <claudiu.beznea@...on.dev>,
        <michal.simek@....com>, <linux@...pel-privat.de>,
        <kernel@...gutronix.de>, <shawnguo@...nel.org>,
        <s.hauer@...gutronix.de>, <festevam@...il.com>, <linux-imx@....com>
CC:     <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/4] i2c: at91-master: devm_pinctrl_get() cannot return
 NULL

Thanks for your patch.Looks good to me.

Acked-by: Hari Prasath Gujulan Elango <Hari.PrasathGE@...rochip.com>

On 17/08/23 1:34 am, Yann Sionneau wrote:
> [You don't often get email from yann@...nneau.net. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Remove unnecessary check against NULL for devm_pinctrl_get() return value.
> 
> Signed-off-by: Yann Sionneau <yann@...nneau.net>
> ---
>   drivers/i2c/busses/i2c-at91-master.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
> index c0c35785a0dc..b598d2439eb1 100644
> --- a/drivers/i2c/busses/i2c-at91-master.c
> +++ b/drivers/i2c/busses/i2c-at91-master.c
> @@ -832,7 +832,7 @@ static int at91_init_twi_recovery_gpio(struct platform_device *pdev,
>          struct i2c_bus_recovery_info *rinfo = &dev->rinfo;
> 
>          rinfo->pinctrl = devm_pinctrl_get(&pdev->dev);
> -       if (!rinfo->pinctrl || IS_ERR(rinfo->pinctrl)) {
> +       if (IS_ERR(rinfo->pinctrl)) {
>                  dev_info(dev->dev, "can't get pinctrl, bus recovery not supported\n");
>                  return PTR_ERR(rinfo->pinctrl);
>          }
> --
> 2.34.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives