linux-kernel - [PATCH] vfio/pds: Limit Calling dev_dbg function to CONFIG_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230905024028.940377-1-oushixiong@kylinos.cn>
Date:   Tue,  5 Sep 2023 10:40:28 +0800
From:   oushixiong <oushixiong@...inos.cn>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Yishai Hadas <yishaih@...dia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Brett Creeley <brett.creeley@....com>,
        Alex Williamson <alex.williamson@...hat.com>,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shixiong Ou <oushixiong@...inos.cn>
Subject: [PATCH] vfio/pds: Limit Calling dev_dbg function to CONFIG_PCI_ATS

From: Shixiong Ou <oushixiong@...inos.cn>

If CONFIG_PCI_ATS isn't set, then pdev->physfn is not defined.
So it causes a compilation issue:

../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
  165 |   __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
      |                              ^~~~~~

Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>
---
 drivers/vfio/pci/pds/vfio_dev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c
index b46174f5eb09..18b4a6a5bc16 100644
--- a/drivers/vfio/pci/pds/vfio_dev.c
+++ b/drivers/vfio/pci/pds/vfio_dev.c
@@ -160,10 +160,13 @@ static int pds_vfio_init_device(struct vfio_device *vdev)
 	vdev->log_ops = &pds_vfio_log_ops;
 
 	pci_id = PCI_DEVID(pdev->bus->number, pdev->devfn);
+
+#ifdef CONFIG_PCI_ATS
 	dev_dbg(&pdev->dev,
 		"%s: PF %#04x VF %#04x vf_id %d domain %d pds_vfio %p\n",
 		__func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
 		pci_domain_nr(pdev->bus), pds_vfio);
+#endif
 
 	return 0;
 }
-- 
2.25.1