linux-kernel - Re: [PATCH v10 net-next 08/23] net/tcp: Add AO sign to RST packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <973ddaf6-0725-8bae-f90b-7921e0104e24@arista.com>
Date:   Tue, 5 Sep 2023 21:04:07 +0100
From:   Dmitry Safonov <dima@...sta.com>
To:     Simon Horman <horms@...nel.org>
Cc:     David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org,
        Andy Lutomirski <luto@...capital.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bob Gilligan <gilligan@...sta.com>,
        Dan Carpenter <error27@...il.com>,
        David Laight <David.Laight@...lab.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Donald Cassidy <dcassidy@...hat.com>,
        Eric Biggers <ebiggers@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Francesco Ruggeri <fruggeri05@...il.com>,
        "Gaillardetz, Dominik" <dgaillar@...na.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Ivan Delalande <colona@...sta.com>,
        Leonard Crestez <cdleonard@...il.com>,
        "Nassiri, Mohammad" <mnassiri@...na.com>,
        Salam Noureddine <noureddine@...sta.com>,
        Simon Horman <simon.horman@...igine.com>,
        "Tetreault, Francois" <ftetreau@...na.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v10 net-next 08/23] net/tcp: Add AO sign to RST packets

Hi Simon,

Sorry for the delayed answer, I went on a vacation.

On 8/16/23 12:50, Simon Horman wrote:
> On Tue, Aug 15, 2023 at 08:14:37PM +0100, Dmitry Safonov wrote:
[..]
>> +	if (tcp_ao_prepare_reset(sk, skb, aoh, l3index, reply->seq,
>> +				 &key, &traffic_key, &allocated_traffic_key,
>> +				 &keyid, &ao_sne))
> 
> Hi Dmitry,
> 
> The type of the 4th parameter of tcp_ao_prepare_reset() (seq) is u32,
> but here a __be32 value is passed.

Yeah, it gets converted in patch "net/tcp: Add TCP-AO sign to twsk".

> Also, it seems that parameter is unused by tcp_ao_prepare_reset().

And only gets used in "net/tcp: Add TCP-AO SNE support".

Hard times when you keep changing the patch set, eventually some nits
and bits get introduced in earlier patches only to be modified by later.

What's worse, I can see that seq is getting used as ntohl(seq) and
tcp_v6_send_reset() does htonl(seq). So, it's better be u32 argument,
introduced by SNE patch, rather than gets converted to-and-back.

Thanks for noticing!

[..]

-- 
           Dmitry