linux-kernel - Re: [PATCH v2 0/2] Fix tps65217-charger vs vbus irq conflict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Sep 2023 09:35:55 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Grant B Adams <nemith592@...il.com>
Cc:     linux-omap@...r.kernel.org, Sebastian Reichel <sre@...nel.org>,
        Bin Liu <b-liu@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Fix tps65217-charger vs vbus irq conflict

* Grant B Adams <nemith592@...il.com> [230823 08:54]:
> Both the tps65217-charger and vbus drivers are trying to allocate the same
> TPS65217 device interrupt line (TPS65217 is a TI power management IC) 
> which results in the following error and a probe failure:
> 
> genirq: Flags mismatch irq 148. 00002000 (vbus) vs. 00000000 
> (tps65217-charger)
> 
> For the Beaglebone Black's config the tps65217-charger driver is currently
> disabled and therefore no conflict. Based on comments from Robert C Nelson
> this driver has been disabled for a long time and he is uncertain on the
> reasons why it was disabled. With a battery connected to the BBB, I 
> re-enabled the tps65217-charger driver which resulted in the 
> abovementioned.
> 
> The conflict is resolved by changing both driver's threaded interrupt
> request function from IRQF_ONESHOT to IRQF_SHARED.

Looks good to me:

Reviewed-by: Tony Lindgren <tony@...mide.com>