linux-kernel - Re: [PATCH v6 2/5] PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74c93380-2f2a-f42d-027a-8c827e794812@gmail.com>
Date:   Tue, 5 Sep 2023 14:24:50 -0600
From:   Sam Edwards <cfsworks@...il.com>
To:     Jim Quinlan <james.quinlan@...adcom.com>,
        linux-pci@...r.kernel.org,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Cyril Brulebois <kibi@...ian.org>,
        Phil Elwell <phil@...pberrypi.com>,
        bcm-kernel-feedback-list@...adcom.com
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Jim Quinlan <jim2101024@...il.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/5] PCI: brcmstb: Configure HW CLKREQ# mode
 appropriate for downstream device

On 6/23/23 08:40, Jim Quinlan wrote:

Hi Jim,

As I understand, the issue that this patch fixes can be difficult to 
trigger reliably. So I'll report that the abort occurs 100% of the time 
on a Compute Module 4, installed in slot 3 of a Turing Pi 2 cluster 
board, when a bootloader (U-Boot, in my case) is in the boot path. The 
third slot of the TP2 board connects to an ASM1061 chip with the CLKREQ# 
line left floating. I do not know why the bootloader is necessary for 
the crash to occur; I suspect it's timing-related.

With this patch applied to my kernel, my observed crash rate goes from 
100% to 0%, so:

> Signed-off-by: Jim Quinlan <james.quinlan@...adcom.com>
> Tested-by: Florian Fainelli <f.fainelli@...il.com>
> Tested-by: Cyril Brulebois <cyril@...amax.com>
Tested-by: Sam Edwards <CFSworks@...il.com>

Many thanks,
Sam