[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJfuBxyRn_FQtGmSiJjtOuJDs+40TPWcjW+JA5u8K-FSrDTHUA@mail.gmail.com>
Date: Wed, 6 Sep 2023 12:06:18 -0600
From: jim.cromie@...il.com
To: Rodrigo Vivi <rodrigo.vivi@...el.com>
Cc: Andi Shyti <andi.shyti@...ux.intel.com>,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
amd-gfx@...ts.freedesktop.org, intel-gvt-dev@...ts.freedesktop.org,
intel-gfx@...ts.freedesktop.org, daniel.vetter@...ll.ch,
daniel@...ll.ch, jani.nikula@...el.com,
ville.syrjala@...ux.intel.com, seanpaul@...omium.org,
robdclark@...il.com, Jani Nikula <jani.nikula@...ux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
David Airlie <airlied@...il.com>,
Imre Deak <imre.deak@...el.com>,
Radhakrishna Sripada <radhakrishna.sripada@...el.com>,
Mika Kahola <mika.kahola@...el.com>,
José Roberto de Souza <jose.souza@...el.com>,
Ankit Nautiyal <ankit.k.nautiyal@...el.com>,
Andrzej Hajda <andrzej.hajda@...el.com>,
Matthew Auld <matthew.auld@...el.com>,
"Jason A. Donenfeld" <Jason@...c4.com>,
Rob Clark <robdclark@...omium.org>,
Chris Wilson <chris@...is-wilson.co.uk>,
Fei Yang <fei.yang@...el.com>
Subject: Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs
On Wed, Sep 6, 2023 at 10:42 AM Rodrigo Vivi <rodrigo.vivi@...el.com> wrote:
>
> On Mon, Sep 04, 2023 at 08:32:40AM +0200, Andi Shyti wrote:
> > Hi Jim,
> >
> > On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote:
> > > By at least strong convention, a print-buffer's trailing newline says
> > > "message complete, send it". The exception (no TNL, followed by a call
> > > to pr_cont) proves the general rule.
> > >
> > > Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> > > 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
> > >
> > > No functional changes.
> > >
> > > Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> >
> > Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com>
>
> I pushed this i915 one to our drm-intel-next.
> While doing it I have changed the subject to make it clear
> this is 'drm/i915:'.
>
> I believe you should do similar change to all the other patches
> to make it clear in the subject about which domain that commit
> is touching... instead of only 'drm_dbg'.
>
I will do that, and drop the one you've already pushed.
Thank you both.
> i.e.: 183670347b06 ("drm/i915: add trailing newlines to msgs")
> https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next&id=183670347b060521920a81f84ff7f10e227ebe05
>
> Thanks for the patch,
> Rodrigo.
>
> >
> > Andi
Powered by blists - more mailing lists