linux-kernel - Re: [PATCH] gpio: zynq: restore zynq_gpio_irq_reqres/zynq_gpio_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <93e5e75d-3cfc-485b-9f81-54c82c58e24e@app.fastmail.com>
Date:   Wed, 06 Sep 2023 16:12:43 -0400
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Thorsten Leemhuis" <regressions@...mhuis.info>,
        "Daniel Mack" <daniel@...que.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        manikanta.guntupalli@....com
Cc:     linux-kernel@...r.kernel.org, stable@...nel.org,
        "Bartosz Golaszewski" <bartosz.golaszewski@...aro.org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Linux kernel regressions list" <regressions@...ts.linux.dev>
Subject: Re: [PATCH] gpio: zynq: restore zynq_gpio_irq_reqres/zynq_gpio_irq_relres
 callbacks

On Wed, Sep 6, 2023, at 09:49, Thorsten Leemhuis wrote:
> CCing Arnd (wrote the culprit), Linus (reviewed it), Bartosz (applied
> it), and the regressions mailing list

Thanks

> On 01.09.23 14:24, Daniel Mack wrote:
>> Commit f56914393537 ("gpio: zynq: fix zynqmp_gpio not an immutable chip
>> warning") ditched the open-coded resource allocation handlers in favor
>> of the generic ones. These generic handlers don't maintain the PM
>> runtime anymore, which causes a regression in that level IRQs are no
>> longer reported.
>> 
>> Restore the original handlers to fix this.
>> 
>> Signed-off-by: Daniel Mack <daniel@...que.org>
>> Fixes: f56914393537 ("gpio: zynq: fix zynqmp_gpio not an immutable chip warning")
>> Cc: stable@...nel.org
>
> This seems to be a regression report that comes straight with a fix, but
> there wasn't a single reply yet afaics. :-/ Maybe the extended list of
> recipients will get things moving. But to ensure this doesn't fall
> through the cracks, I'll add it to the list of tracked regressions.

I don't understand what the GPIOCHIP_IRQ_RESOURCE_HELPERS change
intended to do in the first place: Manikanta's patch changed the behavior
here with the addition of GPIOCHIP_IRQ_RESOURCE_HELPERS, while my patch
was a cleanup that removed the dead code.

Daniel's fix reverts both my cleanup patch and part of the original
change, which may or may not be what we want here.

      Arnd