linux-kernel - [PATCH] mm/shmem: remove dead code can not be satisfied by "(CONFIG_SHMEM)&&(!(CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed,  6 Sep 2023 12:50:12 +0800
From:   sunying@...iscas.ac.cn
To:     akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        pengpeng@...as.ac.cn, Ying Sun <sunying@...iscas.ac.cn>
Subject: [PATCH] mm/shmem: remove dead code can not be satisfied by "(CONFIG_SHMEM)&&(!(CONFIG_SHMEM))"

From: Ying Sun <sunying@...iscas.ac.cn>

The value of “.fs_flags” in line 4608 is a dead code
which will never be implemented，because its conditions of
line 47 "#ifdef CONFIG_SHMEM" and line 4607 are mutually exclusive.
It is recommended to delete redundant code.

Suggested-by: Yanjie Ren <renyanjie01@...il.com>
Signed-off-by: Ying Sun <sunying@...iscas.ac.cn>
---
 mm/shmem.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 13c27c343820..be050efe18cb 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -4602,11 +4602,7 @@ static struct file_system_type shmem_fs_type = {
 	.parameters	= shmem_fs_parameters,
 #endif
 	.kill_sb	= kill_litter_super,
-#ifdef CONFIG_SHMEM
 	.fs_flags	= FS_USERNS_MOUNT | FS_ALLOW_IDMAP | FS_MGTIME,
-#else
-	.fs_flags	= FS_USERNS_MOUNT,
-#endif
 };
 
 void __init shmem_init(void)
-- 
2.17.1