linux-kernel - Re: [PATCH v1] mlxbf-bootctl: add NET dependency into Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b55e7c0-aed2-5225-fcac-1122a985800b@infradead.org>
Date:   Tue, 5 Sep 2023 22:07:33 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     David Thompson <davthompson@...dia.com>, hdegoede@...hat.com,
        markgross@...nel.org, vadimp@...dia.com
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v1] mlxbf-bootctl: add NET dependency into Kconfig


Hi,

On 9/5/23 06:32, David Thompson wrote:
> The latest version of the mlxbf_bootctl driver utilizes
> "sysfs_format_mac", and this API is only available if
> NET is defined in the kernel configuration. This patch
> changes the mlxbf_bootctl Kconfig to depend on NET.
> 
> Reported-by: kernel test robot <lkp@...el.com>

Also
Reported-by: Randy Dunlap <rdunlap@...radead.org>

> Closes: https://lore.kernel.org/oe-kbuild-all/202309031058.JvwNDBKt-lkp@intel.com/
> Signed-off-by: David Thompson <davthompson@...dia.com>
> ---
>  drivers/platform/mellanox/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig
> index 382793e73a60..e52aea996ca5 100644
> --- a/drivers/platform/mellanox/Kconfig
> +++ b/drivers/platform/mellanox/Kconfig
> @@ -60,6 +60,7 @@ config MLXBF_BOOTCTL
>  	tristate "Mellanox BlueField Firmware Boot Control driver"
>  	depends on ARM64
>  	depends on ACPI
> +	depends on NET
>  	help
>  	  The Mellanox BlueField firmware implements functionality to
>  	  request swapping the primary and alternate eMMC boot partition,


I'm sure that this will fix the build problem, but I don't see this
being a network driver. To me it looks like some management s/w
that can run independently of networking software.
It just wants to show/store a MAC address -- no networking.
FWIW.

-- 
~Randy