linux-kernel - Re: [PATCH] MIPS: Alchemy: only build mmc support helpers if au1xmmc is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8e0dd0f-ce37-2dbf-8ac3-a1e26a18cf45@infradead.org>
Date:   Tue, 5 Sep 2023 18:04:18 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Christoph Hellwig <hch@....de>, tsbogend@...ha.franken.de,
        manuel.lauss@...il.com
Cc:     arnd@...db.de, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] MIPS: Alchemy: only build mmc support helpers if au1xmmc
 is enabled



On 9/5/23 00:06, Christoph Hellwig wrote:
> While commit d4a5c59a955b ("mmc: au1xmmc: force non-modular build and
> remove symbol_get usage") to be built in, it can still build a kernel
> without MMC support and thuse no mmc_detect_change symbol at all.
> 
> Add ifdefs to build the mmc support code in the alchemy arch code
> conditional on mmc support.
> 
> Fixes: d4a5c59a955b ("mmc: au1xmmc: force non-modular build and remove symbol_get usage")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  arch/mips/alchemy/devboards/db1000.c | 4 ++++
>  arch/mips/alchemy/devboards/db1200.c | 6 ++++++
>  arch/mips/alchemy/devboards/db1300.c | 4 ++++
>  3 files changed, 14 insertions(+)
> 


Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

-- 
~Randy