linux-kernel - RE: RE: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool cache index corruption.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR1801MB191878F78EA69B499EEF04ECD3EFA@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date:   Wed, 6 Sep 2023 08:46:51 +0000
From:   Ratheesh Kannoth <rkannoth@...vell.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "alexander.duyck@...il.com" <alexander.duyck@...il.com>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "linyunsheng@...wei.com" <linyunsheng@...wei.com>
Subject: RE: RE: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool cache
 index corruption.

> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Subject: Re: RE: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool cache
> index corruption.
> 
> NAPI. (The timer CPU and the worker CPU can be different.) 
ACK. 

> I prefer to be precise what is going on so there are no surprises.
ACK.

 
> I'm not against the worker (with the extra steps) but I prefer to have napi
> schedule done properly.
ACK. Will add local_bh_enable() and keep workqueue. As only interrupt that can
Occur at high rate is rx interrupts, and is disabled while workqueue is scheduled (from NAPI).