[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87il8n4o6u.fsf@minerva.mail-host-address-is-not-set>
Date: Wed, 06 Sep 2023 11:59:37 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Thomas Zimmermann <tzimmermann@...e.de>, deller@....de,
daniel@...ll.ch, sam@...nborg.org, linux-fbdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Cc: linux-kernel@...r.kernel.org,
Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH 3/7] fbdev/core: Fix style of code for boot-up logo
Thomas Zimmermann <tzimmermann@...e.de> writes:
> Fix a number of warnings from checkpatch.pl in this code before
> moving it into a separate file. This includes
>
> * Prefer 'unsigned int' to bare use of 'unsigned'
> * space required after that ',' (ctx:VxV)
> * space prohibited after that open parenthesis '('
> * suspect code indent for conditional statements (16, 32)
> * braces {} are not necessary for single statement blocks
>
> No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
> ---
[...]
> - static const unsigned char mask[] = { 0,0x80,0xc0,0xe0,0xf0,0xf8,0xfc,0xfe,0xff };
> + static const unsigned char mask[] = {
> + 0, 0x80, 0xc0, 0xe0, 0xf0, 0xf8, 0xfc, 0xfe, 0xff
> + };
I didn't know that checkpatch.pl complained about this.
Acked-by: Javier Martinez Canillas <javierm@...hat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Powered by blists - more mailing lists