linux-kernel - Re: [PATCH 1/5] arm64: dts: qcom: qrb2210-rb1: Swap UART index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7bca9767-1112-4817-aac1-e6d720e92817@linaro.org>
Date:   Wed, 6 Sep 2023 14:05:12 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: qcom: qrb2210-rb1: Swap UART index

On 06/09/2023 12:24, Konrad Dybcio wrote:
> Newer RB1 board revisions have a debug UART on QUP0. Sadly, it looks

Nit: I think this is '.. revisions should have...'. Because I was told 
that the board I got is the final design / production.

> like even when ordering one in retail, customers receive prototype
> boards with "Enginering Sample" written on them.
> 
> Use QUP4 for UART to make all known RB1 boards boot.
> 
> Fixes: e18771961336 ("arm64: dts: qcom: Add initial QTI RB1 device tree")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Reported-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

> ---
>   arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> index eadba066972e..5cda5b761455 100644
> --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> @@ -13,7 +13,7 @@ / {
>   	compatible = "qcom,qrb2210-rb1", "qcom,qrb2210", "qcom,qcm2290";
>   
>   	aliases {
> -		serial0 = &uart0;
> +		serial0 = &uart4;
>   		sdhc1 = &sdhc_1;
>   		sdhc2 = &sdhc_2;
>   	};
> @@ -357,7 +357,7 @@ key_volp_n: key-volp-n-state {
>   };
>   
>   /* UART connected to the Micro-USB port via a FTDI chip */
> -&uart0 {
> +&uart4 {
>   	compatible = "qcom,geni-debug-uart";
>   	status = "okay";
>   };
> 

-- 
With best wishes
Dmitry