linux-kernel - block/disk-events.c:302: warning: Excess function parameter 'events' description in 'disk_force_media

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202309060957.vfl0mUur-lkp@intel.com>
Date:   Wed, 6 Sep 2023 10:08:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christoph Hellwig <hch@....de>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Christian Brauner <brauner@...nel.org>,
        Josef Bacik <josef@...icpanda.com>
Subject: block/disk-events.c:302: warning: Excess function parameter 'events'
 description in 'disk_force_media_change'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   65d6e954e37872fd9afb5ef3fc0481bb3c2f20f4
commit: ab6860f62bfe329e11e5b5b7295b673c9c3a62d0 block: simplify the disk_force_media_change interface
date:   2 weeks ago
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20230906/202309060957.vfl0mUur-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230906/202309060957.vfl0mUur-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309060957.vfl0mUur-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> block/disk-events.c:302: warning: Excess function parameter 'events' description in 'disk_force_media_change'


vim +302 block/disk-events.c

d5870edfa3afc46 Christoph Hellwig  2021-06-24  291  
e6138dc12de9df1 Matteo Croce       2021-07-13  292  /**
e6138dc12de9df1 Matteo Croce       2021-07-13  293   * disk_force_media_change - force a media change event
e6138dc12de9df1 Matteo Croce       2021-07-13  294   * @disk: the disk which will raise the event
e6138dc12de9df1 Matteo Croce       2021-07-13  295   * @events: the events to raise
e6138dc12de9df1 Matteo Croce       2021-07-13  296   *
ab6860f62bfe329 Christoph Hellwig  2023-08-11  297   * Should be called when the media changes for @disk.  Generates a uevent
ab6860f62bfe329 Christoph Hellwig  2023-08-11  298   * and attempts to free all dentries and inodes and invalidates all block
e6138dc12de9df1 Matteo Croce       2021-07-13  299   * device page cache entries in that case.
e6138dc12de9df1 Matteo Croce       2021-07-13  300   */
ab6860f62bfe329 Christoph Hellwig  2023-08-11  301  void disk_force_media_change(struct gendisk *disk)
e6138dc12de9df1 Matteo Croce       2021-07-13 @302  {
ab6860f62bfe329 Christoph Hellwig  2023-08-11  303  	disk_event_uevent(disk, DISK_EVENT_MEDIA_CHANGE);
b90ecc0379eb7bb Demi Marie Obenour 2023-06-07  304  	inc_diskseq(disk);
e6138dc12de9df1 Matteo Croce       2021-07-13  305  	if (__invalidate_device(disk->part0, true))
e6138dc12de9df1 Matteo Croce       2021-07-13  306  		pr_warn("VFS: busy inodes on changed media %s\n",
e6138dc12de9df1 Matteo Croce       2021-07-13  307  			disk->disk_name);
e6138dc12de9df1 Matteo Croce       2021-07-13  308  	set_bit(GD_NEED_PART_SCAN, &disk->state);
e6138dc12de9df1 Matteo Croce       2021-07-13  309  }
e6138dc12de9df1 Matteo Croce       2021-07-13  310  EXPORT_SYMBOL_GPL(disk_force_media_change);
e6138dc12de9df1 Matteo Croce       2021-07-13  311  

:::::: The code at line 302 was first introduced by commit
:::::: e6138dc12de9df17cbda9c40314d69592855ac5e block: add a helper to raise a media changed event

:::::: TO: Matteo Croce <mcroce@...rosoft.com>
:::::: CC: Jens Axboe <axboe@...nel.dk>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki