linux-kernel - Re: [PATCH v2 2/2] arm64: dts: mediatek: add device-tree for Genio 1200 EVK board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10cbb316-b08b-a8c1-87dd-00e6ad2aeb7a@mediatek.com>
Date:   Wed, 6 Sep 2023 19:49:11 +0800
From:   Macpaul Lin <macpaul.lin@...iatek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        Sean Wang <sean.wang@...iatek.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>
CC:     Bear Wang <bear.wang@...iatek.com>,
        Pablo Sun <pablo.sun@...iatek.com>,
        Macpaul Lin <macpaul@...il.com>, Ben Lok <ben.lok@...iatek.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: mediatek: add device-tree for Genio
 1200 EVK board



On 9/6/23 18:20, Krzysztof Kozlowski wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On 06/09/2023 12:15, Macpaul Lin wrote:
>>>> +
>>>> +wifi_3v3: wifi-3v3-regulator {
>>>
>>> This is a friendly reminder during the review process.
>>>
>>> It seems my previous comments were not fully addressed. Maybe my
>>> feedback got lost between the quotes, maybe you just forgot to apply it.
>>> Please go back to the previous discussion and either implement all
>>> requested changes or keep discussing them.
>> 
>> 
>> This keeps a format with -regulator is because I've found some other use 
>> cases. It seems "-regulator" or "regulator-" could be arbitrary. I'm not 
>> sure if it is a new guideline for regulator's node. If there is in the 
>> devicetree document, maybe I just missed it?
> 
> What is the point to name in the same DTS some of the regulators
> "regulator-foo" and some "foo-regulator"?
> 
> Best regards,
> Krzysztof
> 

It looks like I've miss the point of previous review comment.
Updated new patch in v3 series.

Thanks
Macpaul Lin