linux-kernel - Re: [PATCH] pinctrl: renesas: pinctrl-rzg2l: Add validation of GPIO pin in rzg2l_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Sep 2023 12:56:10 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     claudiu beznea <claudiu.beznea@...on.dev>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-renesas-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Biju Das <biju.das.jz@...renesas.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] pinctrl: renesas: pinctrl-rzg2l: Add validation of GPIO
 pin in rzg2l_gpio_request()

Hi Claudiu,

Thank you for the review.

On Wed, Sep 6, 2023 at 9:12 AM claudiu beznea <claudiu.beznea@...on.dev> wrote:
>
> Hi, Prabhakar,
>
> On 9/5/23 15:56, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Validate the GPIO pin request in rzg2l_gpio_request() callback using
> > rzg2l_validate_gpio_pin() function. This stops any accidental usage
> > of GPIO pins which are not supported by the SoCs.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> >  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > index 37cdfe4b04f9..4ad08a4b786a 100644
> > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > @@ -795,12 +795,18 @@ static const struct pinconf_ops rzg2l_pinctrl_confops = {
> >  static int rzg2l_gpio_request(struct gpio_chip *chip, unsigned int offset)
> >  {
> >       struct rzg2l_pinctrl *pctrl = gpiochip_get_data(chip);
> > +     const struct pinctrl_pin_desc *pin = &pctrl->desc.pins[offset];
> > +     u64 *pin_data = pin->drv_data;
>
> Maybe move this down a bit to keep the reverse christmas tree order that
> the driver is using as pattern.
>
Sure, will do and send a v2.

> Other than this:
> Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> Tested-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
Thanks for testing.

Cheers,
Prabhakar