linux-kernel - Re: [PATCH] drbd: swap bvec_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169400719806.700937.1715411703006180940.b4-ty@kernel.dk>
Date:   Wed, 06 Sep 2023 07:33:18 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Christoph Böhmwalder 
        <christoph.boehmwalder@...bit.com>
Cc:     drbd-dev@...ts.linbit.com, linux-kernel@...r.kernel.org,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        Philipp Reisner <philipp.reisner@...bit.com>,
        linux-block@...r.kernel.org,
        Linux regression tracking <regressions@...mhuis.info>,
        Serguei Ivantsov <manowar@...-game.com>,
        David Howells <dhowells@...hat.com>, stable@...r.kernel.org
Subject: Re: [PATCH] drbd: swap bvec_set_page len and offset


On Wed, 06 Sep 2023 15:30:34 +0200, Christoph Böhmwalder wrote:
> bvec_set_page has the following signature:
> 
> static inline void bvec_set_page(struct bio_vec *bv, struct page *page,
> 		unsigned int len, unsigned int offset)
> 
> However, the usage in DRBD swaps the len and offset parameters. This
> leads to a bvec with length=0 instead of the intended length=4096, which
> causes sock_sendmsg to return -EIO.
> 
> [...]

Applied, thanks!

[1/1] drbd: swap bvec_set_page len and offset
      commit: 4b9c2edaf7282d60e069551b4b28abc2932cd3e3

Best regards,
-- 
Jens Axboe