linux-kernel - Re: [PATCH v5 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230906140123dd8ffac4@mail.local>
Date:   Wed, 6 Sep 2023 16:01:23 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Mining Lin <mimi05633@...il.com>
Cc:     avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
        venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
        a.zummo@...ertech.it, KWLIU@...oton.com, JJLIU0@...oton.com,
        KFLIN@...oton.com, mylin1@...oton.com, openbmc@...ts.ozlabs.org,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and
 NCT3018Y-R

On 06/09/2023 09:19:29+0800, Mining Lin wrote:
> >> static int nct3018y_set_alarm_mode(struct i2c_client *client, bool on)
> >> {
> >>    int err, flags;
> >> @@ -55,7 +59,7 @@ static int nct3018y_set_alarm_mode(struct i2c_client *client, bool on)
> >>    flags =  i2c_smbus_read_byte_data(client, NCT3018Y_REG_CTRL);
> >>    if (flags < 0) {
> >>        dev_dbg(&client->dev,
> >> -            "Failed to read NCT3018Y_REG_CTRL\n");
> >> +            "%s: Failed to read ctrl reg.\n", __func__);
> > 
> > If you really insist on this change, what about:
> > 
> > #define pr_fmt(fmt) "%s: " fmt, __func__
> [Mia] Do you mean to replace dev_dbg with pr_debug? If yes, for consistency, I'm going to refine all messages via pr_debug. Thank you for your suggestion.

No, I mean that instead of adding __func__ to all the messages just
define pr_fmt, this should achieve what you want.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com