linux-kernel - Re: [PATCH] drm/vmwgfx: fix typo of sizeof argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d304850d6b3e0071dac7928f8dc7c92b25f1a92.camel@vmware.com>
Date:   Wed, 6 Sep 2023 02:44:39 +0000
From:   Zack Rusin <zackr@...are.com>
To:     "konstantin.meskhidze@...wei.com" <konstantin.meskhidze@...wei.com>
CC:     "airlied@...hat.com" <airlied@...hat.com>,
        "thellstrom@...are.com" <thellstrom@...are.com>,
        "yusongping@...wei.com" <yusongping@...wei.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux-graphics-maintainer <Linux-graphics-maintainer@...are.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "artem.kuzin@...wei.com" <artem.kuzin@...wei.com>
Subject: Re: [PATCH] drm/vmwgfx: fix typo of sizeof argument

On Tue, 2023-09-05 at 18:02 +0800, Konstantin Meskhidze wrote:
> Since size of 'header' pointer and '*header' structure is equal on 64-bit
> machines issue probably didn't cause any wrong behavior. But anyway,
> fixing typo is required.
> 
> Fixes: 7a73ba7469cb ("drm/vmwgfx: Use TTM handles instead of SIDs as user-space
> surface handles.")
> Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@...wei-partners.com>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 98e0723ca6f5..cc3f301ca163 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -1619,7 +1619,7 @@ static int vmw_cmd_tex_state(struct vmw_private *dev_priv,
>  {
>         VMW_DECLARE_CMD_VAR(*cmd, SVGA3dCmdSetTextureState);
>         SVGA3dTextureState *last_state = (SVGA3dTextureState *)
> -         ((unsigned long) header + header->size + sizeof(header));
> +         ((unsigned long) header + header->size + sizeof(*header));
>         SVGA3dTextureState *cur_state = (SVGA3dTextureState *)
>                 ((unsigned long) header + sizeof(*cmd));
>         struct vmw_resource *ctx;

Hah, yea, that's an old one. Thanks! I can push it through the drm-misc tree.

Reviewed-by: Zack Rusin <zackr@...are.com>

z