linux-kernel - Re: [PATCH] mfd: cs42l43: Use correct macro for new-style PM runtime ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zg20cfkm.fsf@mail.lhotse>
Date:   Wed, 06 Sep 2023 10:26:17 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Lee Jones <lee@...nel.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        geert@...ux-m68k.org
Subject: Re: [PATCH] mfd: cs42l43: Use correct macro for new-style PM
 runtime ops

Lee Jones <lee@...nel.org> writes:
> On Tue, 22 Aug 2023, Charles Keepax wrote:
>
>> The code was accidentally mixing new and old style macros, update the
>> macros used to remove an unused function warning whilst building with
>> no PM enabled in the config.
>> 
>> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
>> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
>> ---
>>  drivers/mfd/cs42l43.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c
>> index 37b23e9bae823..7b6d07cbe6fc6 100644
>> --- a/drivers/mfd/cs42l43.c
>> +++ b/drivers/mfd/cs42l43.c
>> @@ -1178,8 +1178,8 @@ static int cs42l43_runtime_resume(struct device *dev)
>>  }
>>  
>>  EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = {
>> -	SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
>> -	SET_RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
>> +	SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
>> +	RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
>>  };
>>  
>>  MODULE_DESCRIPTION("CS42L43 Core Driver");
>
> Acked-by: Lee Jones <lee@...nel.org>
>
> If anyone wants to submit this directly to Linus before -rc1, please, be
> my guest.

But you're the MFD maintainer, aren't you? So I think everyone is
expecting you to send it to Linus.

cheers