linux-kernel - Re: [PATCH] LoongArch: Clear invalid tlb when set huge page PTE entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Sep 2023 23:05:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bibo Mao <maobibo@...ngson.cn>, Huacai Chen <chenhuacai@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, WANG Xuerui <kernel@...0n.name>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Clear invalid tlb when set huge page PTE entry

Hi Bibo,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.5 next-20230906]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bibo-Mao/LoongArch-Clear-invalid-tlb-when-set-huge-page-PTE-entry/20230906-013753
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230905044828.1460721-1-maobibo%40loongson.cn
patch subject: [PATCH] LoongArch: Clear invalid tlb when set huge page PTE entry
config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20230906/202309062224.jKf5JY7H-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230906/202309062224.jKf5JY7H-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309062224.jKf5JY7H-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/loongarch/mm/tlb.c:204:6: error: redefinition of 'set_huge_pte_at'
     204 | void set_huge_pte_at(struct mm_struct *mm, unsigned long addr,
         |      ^~~~~~~~~~~~~~~
   In file included from arch/loongarch/mm/tlb.c:9:
   include/linux/hugetlb.h:1175:20: note: previous definition of 'set_huge_pte_at' with type 'void(struct mm_struct *, long unsigned int,  pte_t *, pte_t)'
    1175 | static inline void set_huge_pte_at(struct mm_struct *mm, unsigned long addr,
         |                    ^~~~~~~~~~~~~~~
   arch/loongarch/mm/tlb.c: In function 'set_huge_pte_at':
>> arch/loongarch/mm/tlb.c:215:29: error: implicit declaration of function 'huge_pte_none'; did you mean 'huge_pte_lock'? [-Werror=implicit-function-declaration]
     215 |         if (!cpu_has_ptw && huge_pte_none(*ptep))
         |                             ^~~~~~~~~~~~~
         |                             huge_pte_lock
   arch/loongarch/mm/tlb.c: At top level:
   arch/loongarch/mm/tlb.c:281:6: warning: no previous prototype for 'setup_tlb_handler' [-Wmissing-prototypes]
     281 | void setup_tlb_handler(int cpu)
         |      ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/set_huge_pte_at +204 arch/loongarch/mm/tlb.c

   203	
 > 204	void set_huge_pte_at(struct mm_struct *mm, unsigned long addr,
   205			pte_t *ptep, pte_t pte)
   206	{
   207		/*
   208		 * If huge pte entry is none, tlb entry with normal page size is filled
   209		 * for machines which does not support hardware page walking.
   210		 *
   211		 * Thread maybe migrates to other CPUs after page fault happends and
   212		 * migrates back again after hugepage pte is set, tlbs with normal page
   213		 * about invalid_pte_table need be flushed
   214		 */
 > 215		if (!cpu_has_ptw && huge_pte_none(*ptep))
   216			flush_tlb_mm(mm);
   217	
   218		set_pte_at(mm, addr, ptep, pte);
   219	}
   220	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki