linux-kernel - Re: [PATCH v1 01/10] gpio: pca953x: Drop unused fields in struct pca953x_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPioPzAewLGY9nBo@smile.fi.intel.com>
Date:   Wed, 6 Sep 2023 19:26:39 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 01/10] gpio: pca953x: Drop unused fields in struct
 pca953x_platform_data

On Mon, Sep 04, 2023 at 09:43:01AM +0200, Bartosz Golaszewski wrote:
> On Fri, Sep 1, 2023 at 3:40 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

...

> >         /* number of the first GPIO */
> >         unsigned        gpio_base;
> >
> > -       /* initial polarity inversion setting */
> > -       u32             invert;
> > -
> >         /* interrupt base */
> >         int             irq_base;
> > -
> > -       void            *context;       /* param to setup/teardown */
> > -
> > -       int             (*setup)(struct i2c_client *client,
> > -                               unsigned gpio, unsigned ngpio,
> > -                               void *context);
> > -       void            (*teardown)(struct i2c_client *client,
> > -                               unsigned gpio, unsigned ngpio,
> > -                               void *context);
> > -       const char      *const *names;
> 
> Ah, we're so close to getting rid of platform data entirely...

Yep!

> Series looks good to me, I'll pick it up next week after the merge
> window closes.

Sure, thank you for the review!

-- 
With Best Regards,
Andy Shevchenko