linux-kernel - Re: [PATCH v2] x86: Remove the arch_calc_vm_prot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2114d5c0-3903-f4be-795b-829c3a1e5f9f@intel.com>
Date:   Wed, 6 Sep 2023 10:01:20 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Thomas Huth <thuth@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>
Cc:     Nicolas Schier <nicolas@...sle.eu>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, Arnd Bergmann <arnd@...db.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86: Remove the arch_calc_vm_prot_bits() macro from
 the uapi

On 9/6/23 09:26, Thomas Huth wrote:
> The arch_calc_vm_prot_bits() macro uses VM_PKEY_BIT0 etc. which are
> not part of the uapi, so the macro is completely useless for userspace.
> It is also hidden behind the CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
> config switch which we shouldn't expose to userspace. Thus let's move
> this macro into a new internal header instead.
> 
> Fixes: 8f62c883222c ("x86/mm/pkeys: Add arch-specific VMA protection bits")
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Nicolas Schier <nicolas@...sle.eu>
> Signed-off-by: Thomas Huth <thuth@...hat.com>

Gah, sorry this got dropped.  I went to go throw it in my review queue
and saw your last version in there.  I plan to apply it (this time)
shortly after we see -rc1.

In any case:

Acked-by: Dave Hansen <dave.hansen@...el.com>