linux-kernel - Re: [PATCH 0/5] Add new platform support for DBC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d9af84b-59e8-385e-5dff-0f12651fab52@amd.com>
Date:   Thu, 7 Sep 2023 16:28:12 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Mario Limonciello <mario.limonciello@....com>,
        herbert@...dor.apana.org.au, davem@...emloft.net
Cc:     john.allen@....com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rijo-john.Thomas@....com
Subject: Re: [PATCH 0/5] Add new platform support for DBC

On 9/7/23 13:48, Mario Limonciello wrote:
> Some platforms that support dynamic boost control (DBC) support it via
> a different mailbox than the platform access mailbox.
> 
> This series adds support for those platforms.
> 
> It is tested on top of the fixes series. The prerequisite patches refer
> to that series.
> Link: https://lore.kernel.org/linux-crypto/20230829150759.156126-1-mario.limonciello@amd.com/T/#m47782729377f6fe5d62130cc701dae7f15306726
> 
> Mario Limonciello (4):
>    crypto: ccp: Add support for extended PSP mailbox commands
>    crypto: ccp: Add a communication path abstraction for DBC
>    crypto: ccp: Add a macro to check capabilities register
>    crypto: ccp: Add support for DBC over PSP mailbox
> 
> Tom Lendacky (1):
>    crypto: ccp: Move direct access to some PSP registers out of TEE
> 
>   drivers/crypto/ccp/dbc.c     |  72 ++++++++++++++-------
>   drivers/crypto/ccp/dbc.h     |  29 +++------
>   drivers/crypto/ccp/psp-dev.c | 122 ++++++++++++++++++++++++++++-------
>   drivers/crypto/ccp/psp-dev.h |  55 ++++++++++++++++
>   drivers/crypto/ccp/sp-dev.h  |   4 ++
>   drivers/crypto/ccp/sp-pci.c  |  22 ++++---
>   drivers/crypto/ccp/tee-dev.c |  48 +++-----------
>   drivers/crypto/ccp/tee-dev.h |  15 +----
>   8 files changed, 241 insertions(+), 126 deletions(-)
> 

Acked-by: Tom Lendacky <thomas.lendacky@....com>

But I would like to see a Reviewed-by: or Tested-by: from Rijo-john for 
the TEE changes.

Thanks,
Tom

> 
> base-commit: 7ba2090ca64ea1aa435744884124387db1fac70f
> prerequisite-patch-id: 4bcf7f3ea21472e4e28c2457cc9827f6023ec6ca
> prerequisite-patch-id: 903be53a20306f0188e52015dbfe5196738bb2eb
> prerequisite-patch-id: af396bafb6acaa9c203c1a2c5f4665171cb45e4f
> prerequisite-patch-id: abe450d4bf1de4a5664a41dbf84e72b1d4bfdae7
> prerequisite-patch-id: b0b9cf55fcb73a11de6f3da73412fb090562857a